Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guidances for TLDs and Wildcard specification in YAML #24949

Closed
wants to merge 1 commit into from
Closed

Add guidances for TLDs and Wildcard specification in YAML #24949

wants to merge 1 commit into from

Conversation

distributethe6ix
Copy link

There were a few issues that requested how to specify WILDCARDS in YAML for Top-level-domains (TLDs). This is not currently supported and requires someone doing this to own all TLDs.

@k8s-ci-robot
Copy link
Contributor

Welcome @distributethe6ix!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 7, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 7, 2020
@netlify
Copy link

netlify bot commented Nov 7, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 113f88b

https://deploy-preview-24949--kubernetes-io-master-staging.netlify.app

@netlify
Copy link

netlify bot commented Nov 7, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit baee4f2

https://deploy-preview-24949--kubernetes-io-master-staging.netlify.app

Arhell
Arhell reviewed Nov 8, 2020
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@distributethe6ix
Pls sign the CLA in order for the PR to be reviewed.

@RA489
Copy link

RA489 commented Nov 11, 2020

/check-cla

@distributethe6ix
Copy link
Author

Fixes kubernetes/kubernetes#41881

@distributethe6ix
Copy link
Author

CLA has been signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Aut0R3V
To complete the pull request process, please assign zacharysarah after the PR has been reviewed.
You can assign the PR to them by writing /assign @zacharysarah in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@distributethe6ix
Copy link
Author

/assign @zacharysarah

sftim
sftim reviewed Jan 12, 2021
View reviewed changes
content/en/docs/concepts/services-networking/ingress.md
Comment on lines +206 to +209
With respect to Wildcards and Top-level-domains (eg. .com, .ca, .org, .edu), there is
currently no support for specifying a wildcard in the format of `subdomain.domain.*`.
This would assume that the domain owner has access to and purchased all
Top-level-domains for their domain in order for this to be supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is needed @distributethe6ix

“Wildcard matches require the HTTP host header is equal to the suffix of the wildcard rule.” already covers this, I think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@distributethe6ix

Suggested change
With respect to Wildcards and Top-level-domains (eg. .com, .ca, .org, .edu), there is
currently no support for specifying a wildcard in the format of `subdomain.domain.*`.
This would assume that the domain owner has access to and purchased all
Top-level-domains for their domain in order for this to be supported.

Remove this paragraph (accept the above suggestion) and we can merge this in?

Copy link
Author

@distributethe6ix distributethe6ix Mar 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Wildcard matches require the HTTP host header is equal to the suffix of the wildcard rule.” does not satisfy what the original issue was asking for.

With respect to Ingress, you cannot specify a Top level domain wild-card, hence why I added this bit into the documentation. It's not clear otherwise.

The top-level-domain is the ".com, .ca, .org, .io" for example, is not part of the "host-field"

The wildcard functionality does not address situations where someone who has purchased multiple domains can route accordingly to .ca, .com.

There is no option for host.foo.* <--- Wildcard at the TLD...

Happy to hop on a zoom/discord chat to further provide clarification.

@Aut0R3V Aut0R3V mentioned this pull request Jan 16, 2021
Closed
6 tasks
@tengqm
Copy link
Contributor

tengqm commented Mar 29, 2021

@distributethe6ix Please respond to the comments so we can move on with this.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2021
@kbhawkey
Copy link
Contributor

👋 @distributethe6ix .
Since there has been no recent activity, I plan to close this pull request.
/close

@k8s-ci-robot
Copy link
Contributor

@kbhawkey: Closed this PR.

In response to this:

👋 @distributethe6ix .
Since there has been no recent activity, I plan to close this pull request.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@celestehorgan celestehorgan celestehorgan left review comments

@Aut0R3V Aut0R3V Aut0R3V approved these changes

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

@tengqm tengqm Awaiting requested review from tengqm

@Arhell Arhell Awaiting requested review from Arhell

Assignees

@zacharysarah zacharysarah

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.